Repository navigation
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 57 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aee3a739eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| text = document.read_text(encoding="utf-8") | ||
| for block in c.RESOLUTION.findall(c.unfenced(text)): | ||
| if json.loads(block).get("note") == key: | ||
| entry = json.loads(block) |
There was a problem hiding this comment.
If any concept contains an existing resolution block for a different note, this assignment overwrites the receipt payload constructed above with that unrelated resolution. receipt_text(note, entry) then writes the previous note's disposition and JSON under the new note's receipt filename, ignoring the requested resolution. Subsequent check rejects the receipt, and retrying resolve-note is blocked because the file already exists. Use a separate variable for the scanned resolution so the validated receipt payload remains intact.
Useful? React with 👍 / 👎.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
Closes #6857
Verification
python3 -I -m unittest discover -s scripts/tests -p 'test_*workflow*.py' -v: research workflow suites passed; 119 passed, with one unrelated auto-format test failing.git diff --checkpassed.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.